chore(heatmap): drop unused export of HeatmapChartConfig type#2227
chore(heatmap): drop unused export of HeatmapChartConfig type#2227kodiakhq[bot] merged 1 commit intomainfrom
Conversation
No external file imports HeatmapChartConfig by name. DBDashboardPage, ChartPreviewPanel, and DBSearchHeatmapChart all use the inferred return type of toHeatmapChartConfig(...). The type stays in use locally for the function return shape and prop annotations. OSS knip 6.0.1 currently does not flag this; EE's knip resolved to 6.0.3 after the lockfile diverged and started failing on every heatmap-touching downstream merge (see DeploySentinel/hyperdx-ee#1997 for the most recent occurrence). Dropping the export here prevents the next OSS-to-EE sync from re-introducing the same fixup. Co-Authored-By: Claude Opus 4.7 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
github-actions
Bot
added
the
review/tier-2
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
PR Review✅ No critical issues found. Verified |
|
<!-- compound-engineering-review --> Compound Engineering Review✅ No critical issues found. Single-line cleanup:
No P0/P1/P2 findings. The change does exactly what the commit message says and nothing more. |
E2E Test Results✅ All tests passed • 164 passed • 3 skipped • 1183s
Tests ran across 4 shards in parallel. |
2 participants
Summary
exportfromHeatmapChartConfiginpackages/app/src/components/DBHeatmapChart.tsx. No external file imports the type by name; consumers (DBDashboardPage,ChartPreviewPanel,DBSearchHeatmapChart) use the inferred return oftoHeatmapChartConfig(...). The type stays in use locally for the function return shape and prop annotations.Why
OSS knip 6.0.1 happens not to flag this. EE's lockfile resolved knip to 6.0.3 after the recent divergence, and the stricter minor flags inferred-only exports as unused. Result: every heatmap-touching downstream merge into
DeploySentinel/hyperdx-eefails knip on this single line and needs a manual fixup. Most recent occurrence: DeploySentinel/hyperdx-ee#1997 (heatmap wire-up upstream merge of #2107). Dropping the export here lets the next merge cycle pass cleanly.Behavior-neutral. No runtime impact. No changeset (not user-visible).
Test plan
yarn nx run @hyperdx/common-utils:ci:buildyarn nx run @hyperdx/app:ci:lintyarn knip:ci({"issues":[]}, exit 0)